fix: VSCodeNotifyVisual and VSCodeCallVisual produce incorrect VSCode selections in visual and visual block modes if the cursor is placed at the beginning of the visual selection #1180
+45
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selections in visual and visual block modes if the cursor is placed at the beginning of the visual selection
justinmk
reviewed
Mar 21, 2023
vim/vscode-neovim.vim
Outdated
Comment on lines
62
to
66
| if (startPos[1] == endPos[1] && startPos[2] > endPos[2]) || startPos[1] > endPos[1] | ||
| let startPos[2] = startPos[2] + 1 | ||
| else | ||
| let endPos[2] = endPos[2] + 1 | ||
| endif |
There was a problem hiding this comment.
since this is used in multiple places, it's worth extracting it to a function like fixVisualPos(). That gives a hint to future readers that happen to look at this function. Also helps if a bug fix is needed.
Is it possible to add a test?
There was a problem hiding this comment.
@justinmk, I've extracted duplicated logic into the s:fixVisualPos function and added a test.
justinmk
approved these changes
Apr 23, 2023
theol0403
added a commit
to theol0403/vscode-neovim
that referenced
this pull request
Jun 27, 2023
chore(master): release 0.1.0 BEGIN_COMMIT_OVERRIDE feat: Neovim toggle (vscode-neovim#1033) fix: wrong VSCode selections if cursor is at start of selection vscode-neovim#1180 feat: add $NVIM_APPNAME option (vscode-neovim#1186) feat: use k instead of i to moveEditorToAboveGroup (vscode-neovim#1119) feat(ci): add automatic releases (and switch to semantic versioning) END_COMMIT_OVERRIDE
theol0403
added a commit
to theol0403/vscode-neovim
that referenced
this pull request
Jun 27, 2023
BEGIN_COMMIT_OVERRIDE feat: Neovim toggle (vscode-neovim#1033) fix: wrong VSCode selections if cursor is at start of selection vscode-neovim#1180 feat: add $NVIM_APPNAME option (vscode-neovim#1186) feat: use k instead of i to moveEditorToAboveGroup (vscode-neovim#1119) feat(ci): add automatic releases (and switch to semantic versioning) END_COMMIT_OVERRIDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes VSCodeNotifyVisual and VSCodeCallVisual producing incorrect VSCode selections in visual and visual block modes when the cursor is placed at the beginning of the visual selection.
vim.keymap.set("x", "<D-d>, "<Cmd>call VSCodeNotifyVisual('editor.action.addSelectionToNextFindMatch', 1)<CR><Esc>i", opts)mapping was used in the examples below.But the problem exists for all mappings that call either
VSCodeNotifyVisualorVSCodeCallVisual.Before
Screen.Recording.2023-03-18.at.16.41.11.mp4
After
Screen.Recording.2023-03-18.at.16.38.41.mp4