typo? use k instead of i to moveEditorToAboveGroup

[ctstacey]

No description provided.

[theol0403]

Not a typo. Mentioned in readme. C-k clashes with many vscode bindings.

[ctstacey]

Hi @theol0403,
Thanks for pointing it out in the readme, I missed that :)

I wonder though...
It looks like Ctrl+k is already being sent to neovim when not in insert mode (and the user has set neovim.ctrlKeysNormal causing ctrl key combos to be sent to neovim when not in insert mode).

vscode-neovim/package.json

Lines 791 to 796 in 30f268b

	{
	"command": "vscode-neovim.send",
	"key": "ctrl+k",
	"when": "editorTextFocus && neovim.init && neovim.mode != insert && neovim.ctrlKeysNormal",
	"args": "<C-k>"
	},

<C-w><C-k> mapping would only be used in normal and visual mode (n and x)

vscode-neovim/vim/vscode-window-commands.vim

Lines 111 to 112 in 30f268b

	nnoremap <C-w><C-i> <Cmd>call VSCodeNotify('workbench.action.moveEditorToAboveGroup')<CR>
	xnoremap <C-w><C-i> <Cmd>call VSCodeNotify('workbench.action.moveEditorToAboveGroup')<CR>

If user has not set neovim.ctrlKeysNormal, Ctrl+w wouldn't be sent in either normal or visual modes (n or x) regardless.

If you're willing to re-consider, please re-open this PR and I'll update the readme as well.
Sincerely,
Chris

[ctstacey]

Ready for review/suggestions, thanks :)

[ctstacey]

Was the version already bumped?
Would this actually be released in 0.0.96?

[theol0403]

This would be added to 0.0.97.

[theol0403]

Thank you for all your PRs!