feat: add $NVIM_APPNAME option #1186
Conversation
There was a problem hiding this comment.
Things like https://github.com/direnv/direnv-vscode are a generalized way to set the vscode environment.
But this PR probably probably is still needed so that the setting can be vscode-specific.
I wish vscode would just make it possible to set env vars in settings.json. (You can read them via ${env:FOO} but I don't know if you can set them?)
|
Now that neovim 0.9 was released, can this be merged? |
|
Does this PR break the extension when neovim is < 0.9? If so we should at least bump the minimal required version and probably wait a while until users have had the chance to update.
|
No, works fine on 0.8.3 |
|
+1 would love for this to be merged @justinmk |
chore(master): release 0.1.0 BEGIN_COMMIT_OVERRIDE feat: Neovim toggle (vscode-neovim#1033) fix: wrong VSCode selections if cursor is at start of selection vscode-neovim#1180 feat: add $NVIM_APPNAME option (vscode-neovim#1186) feat: use k instead of i to moveEditorToAboveGroup (vscode-neovim#1119) feat(ci): add automatic releases (and switch to semantic versioning) END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE feat: Neovim toggle (vscode-neovim#1033) fix: wrong VSCode selections if cursor is at start of selection vscode-neovim#1180 feat: add $NVIM_APPNAME option (vscode-neovim#1186) feat: use k instead of i to moveEditorToAboveGroup (vscode-neovim#1119) feat(ci): add automatic releases (and switch to semantic versioning) END_COMMIT_OVERRIDE
neovim/neovim#22128
Personally I want a separate neovim config just for vscode, which can be achieved by setting
$NVIM_APPNAME