fix: set highlight group Subsitute

[xiyaowong]

chore: remove the border of the custom highlights
It will be strange when multiple decoration ranges with borders are connected.

• Fix bug: incremental highlights do not work if inccommand is not empty #1979

[xiyaowong]

set icm=nosplit works, but sometimes the highlighing is wrong

Code_-_Insiders_RYU3vSr4BI.00_00_00-00_00_23.mp4

[xiyaowong]

set icm=nosplit works, but sometimes the highlighing is wrong

Hard to reproduce with #1976

[ollien]

Nice! We should offer a way to customize these colors if possible, though. I can imagine this color not showing very well on some light themes.

[xiyaowong]

Now it's possible, the setup_globals will only execute once, and users can define it themselves, requiring some delay for custom highlighting. However, indeed, there is a need to provide a more conventional approach.

[ollien]

Gotcha, I guess I was thinking of allowing it via our configuration, but init.vim works too

[xiyaowong]

microsoft/vscode#32813

[ollien]

One thing I noticed, though I figure we can't do much about this, given VSCode owns the buffer, is that any substitutions that exceed the length of the original match will visually write over text later in the line. In Neovim, the original text is visually removed when typing your substitution.

Similarly (and this one I think we could fix), if your substitution exceeds the line length, it gets weirdly truncated.

[xiyaowong]

Merged, this PR has no side effects

[theol0403]

Should we not be using vscode-neovim.highlightGroups.highlights to provide the default? Then we can pick theme colors.

[xiyaowong]

I originally used ThemeColor, but later found that the effect was not good

vscode-neovim/runtime/lua/vscode-neovim/highlight.lua

Lines 58 to 62 in c81e64d

	-- By default, it's linked to Search.
	-- But Search highlighting defaults to using VSCode ThemeColor, potentially with some opacity.
	-- When the decoration is "virtText", having a background color with opacity can
	-- cause the virtual text to blend with the original content.
	Substitute = { fg='#282c34', bg='#98c379' },

[theol0403]

Just don't link it to Search, but provide the colors through package.json. That way it is configurable and you can access any ThemeColor you want.

[xiyaowong]

Sure. But now users can still set it in settings.json. If you want to add to this, that's fine with me.

[ollien]

But now users can still set it in settings.json

How would users do that now? I can guess how they might do it in init.vim, but not settings.json

[xiyaowong]

But now users can still set it in settings.json

How would users do that now? I can guess how they might do it in init.vim, but not settings.json

https://github.com/vscode-neovim/vscode-neovim#-highlights