Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wildmenu items are being set repeatedly #1989

Merged
merged 1 commit into from
May 20, 2024

Conversation

xiyaowong
Copy link
Collaborator

@xiyaowong xiyaowong commented May 20, 2024

A mistake made in #1985

Copy link
Collaborator

@ollien ollien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, nice!

Just because I'm curious, what was the "loop" here? I was trying to narrow it down and the best I could find was that commenting this check out seemed to stop the problem, but I couldn't figure out why this caused cmdline_show events to be re-fired.

        if (this.isDisplayed && this.completionItems.length) {
            this.input.items = this.completionItems;
        }

@xiyaowong
Copy link
Collaborator Author

When in cmdline, nvim will continuously send cmdline_show event.

@xiyaowong xiyaowong merged commit fc48f03 into vscode-neovim:master May 20, 2024
8 checks passed
@xiyaowong xiyaowong deleted the fix/wildmenu branch May 20, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants