fix: Support inccommand, including "split" #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Use of wildmenu is clever here. One bug, though I wouldn't say it's a big deal for most cases, is you can't really scroll in this list, either with the arrow keys or the mouse wheel. Are the redraw events being sent repeatedly, or something? recording-2024-05-19_11.38.14.mp4 |
|
It's expected. You can't do anything in nvim's preview window either. |
fix: wildmenu sometimes not showing
ollien
approved these changes
May 19, 2024
|
@xiyaowong I actually think the quickpick bug I reported above has spread to all other instances of wildmenu. I'm trying to narrow down a cause a bit, but if I come up empty, I'll file a formal issue for it |
|
Confirmed.
No need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: wildmenu sometimes not showing
Code_-_Insiders_lkN6271KCt.mp4
BEGIN_COMMIT_OVERRIDE
feat: Support inccommand, including "split"
fix: wildmenu sometimes not showing
END_COMMIT_OVERRIDE