fix(incsearch): viewport is not updating during searching #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xiyaowong
commented
Oct 28, 2023
xiyaowong
commented
- Resolve: Search replace with confirmation :%s/foo/bar/gc does not scroll automatically #1149
- Resolve: bug: ghost text in editor window when using vim search #1555
justinmk
reviewed
Oct 28, 2023
|
This feels like a hack, and I don't really like the added code. Is there any other possible fix that is more generic? |
|
Neovim did not send the corresponding grid information during incsearch, and no relevant instructions were found in the neovim documentation. @justinmk This 'hack' is currently the simplest one among the solutions I have tried. |
|
It used to work before your highlight manager refactor... do you know why it broke? |
|
No, this is a problem that has always existed. I tested 0.3.2 💆🏻♂️ It is fundamentally unrelated to highlighting. |
theol0403
approved these changes
Oct 29, 2023
|
This problem can only be easily reproduced in clean mode. Most people(including me) don't encounter this problem because they use a search plugin or execute nohl after searching |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.