Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate BufWriteCmd for "write" command #2116

Merged
merged 15 commits into from
Jun 22, 2024

Conversation

xiyaowong
Copy link
Collaborator

@xiyaowong xiyaowong commented Jun 16, 2024

  • Works
  • Remote
    remote
  • Add tests
  • Update readme

close #2075

@theol0403
Copy link
Member

I found an edge behavior, not sure if this is intentional or a minor bug.

If you make a change, then undo it, you are back to the last saved version but the vscode dirty status is still enabled. However, running :wall doesn't clear that dirty status (like it used to). :w properly clears it.

@xiyaowong
Copy link
Collaborator Author

I found an edge behavior, not sure if this is intentional or a minor bug.

If you make a change, then undo it, you are back to the last saved version but the vscode dirty status is still enabled. However, running :wall doesn't clear that dirty status (like it used to). :w properly clears it.

This needs to be done in a separate PR. Once the document modifications are synchronized, updating this status will suffice. Additionally, even if a special circumstance causes the status to be incorrect, it's okay; it's not very important.

src/buffer_manager.ts Outdated Show resolved Hide resolved
src/buffer_manager.ts Outdated Show resolved Hide resolved
src/buffer_manager.ts Outdated Show resolved Hide resolved
@xiyaowong
Copy link
Collaborator Author

I have updated the README. Please review

@xiyaowong xiyaowong requested a review from justinmk June 21, 2024 15:46
@xiyaowong xiyaowong merged commit 8606eb1 into vscode-neovim:master Jun 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants