Fix b on long lines #775
Merged
Fix b on long lines #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The deleted code sure looks attractive :) Possible to write some sort of test? At least to exercise the codepath. Rebasing will fix CI. |
|
I've been using this for a while and it seems to work well. In addition, I think the codepath is already excersized by tests because it is a core part of the plugin. I think it also fixes a bug where lots of j/k up and down on the end of the line won't return to the same col after a bit. |
theol0403
approved these changes
Jun 30, 2022
|
Additionally, I think this fixes a problem where some jumps don't get registered in jumplist, because they come from a sequence of cursormove commands. |
Jendker
added a commit
to Jendker/vscode-neovim
that referenced
this pull request
Feb 19, 2023
This reverts commit f783274.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #773 and partially addresses #573.
Somehow a sequence of cursorMove commands is causing a bug in vscode. Removing them and directly setting the cursor location solves this issue. We don't need cursorMove vscode commands in this case anyways as less than one line move does not seem to get registered in jumplist.
Since the extension is getting highlights from redraw notifications, which is limited by window size, and neovim did not make the starting column of the current viewport in buffer available in the drawing notifications, the visual mode still displays incorrectly in vscode. However, it seems like the actual editing itself is working properly. There is no good fix to this other than implementing the display part of visual mode in the extension.