Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] LanguageClient does not pass on environment variables #404

Closed
mgrosvenor opened this issue Aug 31, 2022 · 0 comments
Closed

[Bug] LanguageClient does not pass on environment variables #404

mgrosvenor opened this issue Aug 31, 2022 · 0 comments

Comments

@mgrosvenor
Copy link
Contributor

mgrosvenor commented Aug 31, 2022 •
edited

The launch code for the Exbonio server does not pass on local environment variables. This means that the PYTHONPATH setting does not carry through to the sphinx-build tool, which means that it cannot find extensions that are in custom paths (ie not in the system path).
@mgrosvenor mgrosvenor changed the title LanguageClient does not pass on environment variables [Bug] LanguageClient does not pass on environment variables Aug 31, 2022
@mgrosvenor mgrosvenor mentioned this issue Sep 1, 2022
Merged
@lextm lextm closed this as completed in 4aeb4b3 Sep 1, 2022
lextm added a commit that referenced this issue Sep 1, 2022
@lextm
Merge pull request #405 from mgrosvenor/404-pass-env-vars-through
e961dbf 
Pass shell environment though to Sphinx process (Fixes issue #404)
@twodrops twodrops mentioned this issue Sep 6, 2022
Closed
lextm pushed a commit that referenced this issue Sep 10, 2022
@mgrosvenor @lextm
Fix #404
ac4f2e8 
By setting `shell=true` in the options structure, environment variables from the calling process are passed down into the `sphinx-build` process. This includes the `PYTHONPATH` variable, which allows Sphinx to find modules that are not in the default system path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgrosvenor