Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to shellcheck.ignorePatterns instead of overriding it #1196

Open
lonix1 opened this issue Aug 24, 2023 · 2 comments
Open

Add to shellcheck.ignorePatterns instead of overriding it #1196

lonix1 opened this issue Aug 24, 2023 · 2 comments

Comments

@lonix1
Copy link

lonix1 commented Aug 24, 2023

I want to ignore a certain massive directory (dependencies outside my control).

I found the shellcheck.ignorePatterns setting. But it already has a large default value:

  "shellcheck.ignorePatterns": {
    "**/*.csh": true,
    "**/*.cshrc": true,
    "**/*.fish": true,
    "**/*.login": true,
    "**/*.logout": true,
    "**/*.tcsh": true,
    "**/*.tcshrc": true,
    "**/*.xonshrc": true,
    "**/*.xsh": true,
    "**/*.zsh": true,
    "**/*.zshrc": true,
    "**/zshrc": true,
    "**/*.zprofile": true,
    "**/zprofile": true,
    "**/*.zlogin": true,
    "**/zlogin": true,
    "**/*.zlogout": true,
    "**/zlogout": true,
    "**/*.zshenv": true,
    "**/zshenv": true,
    "**/*.zsh-theme": true
  },

I don't want to override the defaults, only add one line to it (e.g. **/bin/**). How can I do that?

@felipecrs
Copy link
Collaborator

That's not possible, but I see no problems adding a shellcheck.additionalIgnorePatterns option. PRs welcome.

@lonix1
Copy link
Author

lonix1 commented Aug 24, 2023

A shellcheck.additionalIgnorePatterns would be a nice solution. I'm not a vscode plugin dev though. Maybe someone will find this and be inspired.

Also, I suppose I could recreate the default list in my config, and add a new line to it? That would be helluva ugly and lower maintainability but should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants