Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippets in actions and more #99

Merged
merged 3 commits into from
May 6, 2023
Merged

Conversation

RblSb
Copy link
Member

@RblSb RblSb commented May 2, 2023

  • Clients can pass supported commands to enable more experimental features
  • If client has insertSnippet command, use it in function generation, arg generation and var extraction
  • Check for command support in codeaction resolve requests, to prevent double command calls. This support is already in VSCode Insiders and can be released in days.
  • Better arg names in function generation
  • Move arg generation to QuickFix: currently if you want to fix arg error and open action menu, this fix is after extract var, because of RefactorRewrite category. I really want to keep this as quickfix, to keep all code fixes at the top of actions list for better ux
  • Indentation fixes for multiline values in var extraction and nullCoal generators

@AlexHaxe AlexHaxe merged commit d01844c into vshaxe:master May 6, 2023
2 checks passed
@RblSb RblSb deleted the actions_snippets branch May 6, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants