Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make debug builds usable without debugging #3

Closed
Gama11 opened this issue Jul 4, 2018 · 3 comments
Closed

Make debug builds usable without debugging #3

Gama11 opened this issue Jul 4, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@Gama11
Copy link
Member

Gama11 commented Jul 4, 2018

Right now, a debug build repeatedly tries to connect to the server when compiled with the hxcpp-debug-server lib and doesn't start until it does. This makes it unusable for anything but debugging, which can be a bit annoying.

One thing we could do is launch the executable with a HXCPP_DEBUGGER environment variable defined, and Server would only be instantiated if that env variable is present. However, that might cause issues when trying to support attach requests (#1).

@nulld Thoughts?

@Gama11 Gama11 added the enhancement New feature or request label Jul 4, 2018
@Gama11
Copy link
Member Author

Gama11 commented Jul 4, 2018

The Server.connect() loop could maybe also be non-blocking to still allow the application to start? Probably enough to move it to debuggerThreadMain to allow for that. In that case, we might need a stopOnEntry property like the Node debugger has though so you have a way to make sure breakpoints on startup aren't missed.

@nulld
Copy link
Member

nulld commented Jul 4, 2018

I thought to limit number of tries will be enough, and start listening on same port for attach request if last try failed.

@Gama11
Copy link
Member Author

Gama11 commented Jul 5, 2018

Sure, that probably works too.

nulld pushed a commit that referenced this issue Jul 5, 2018
@nulld nulld closed this as completed Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants