Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haxe-language-server doesn't work until the first onDidChangeConfiguration event #359

Open
joshtynjala opened this issue Jun 19, 2019 · 6 comments
Labels

Comments

@joshtynjala
Copy link
Contributor

This is a request to document in the readme that there's a requirement to send a didChangeConfiguration notification as part of initializing the Haxe language server.

Making the notification optional would also be fine.

I ran into this issue trying to get the Haxe language server working in Moonshine IDE. Everything seemed to work up through the initialized notification, and then the language server didn't accept any further requests, like hover, definition or completion.

Luckily, I'm the one who implemented the client side of the protocol in Moonshine, so I can ensure that this notification is always sent. In my initial tests, adding this notification after init doesn't seem to hurt any existing language servers that I've previously integrated that worked fine without it.

@Gama11
Copy link
Member

Gama11 commented Jun 19, 2019

I think it's actually part of the LSP spec that there's an initial onDidChangeConfiguration?

@joshtynjala
Copy link
Contributor Author

@Gama11 I'm not seeing that mentioned in the spec...

@Gama11
Copy link
Member

Gama11 commented Jun 19, 2019

I might be wrong, but then we should actually change this as it would be a violation of the spec, not document it. I think other language clients actually struggled with this too.

@joshtynjala
Copy link
Contributor Author

Yeah, I figured out that this notification was needed based on the comments in #171 and #328 related to Neovim and Sublime.

@Gama11 Gama11 added the bug label Jun 19, 2019
@jdonaldson
Copy link

I ran into this as well, it required a lot of debugging and code tracing to figure out what was going wrong.

@Gama11 Gama11 changed the title Documentation: haxe-language-server doesn't work until the first onDidChangeConfiguration event haxe-language-server doesn't work until the first onDidChangeConfiguration event Jan 4, 2020
@kLabz
Copy link
Contributor

kLabz commented Dec 23, 2022

We might want to rework this workflow, apparently there's workspace/configuration which could lead to less issues.

Adding this for reference, will look into this later: microsoft/language-server-protocol#567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants