Completion for "override function"

[kevinresol]

Shows a list of overridable functions at override | or override function |

[Gama11]

I very much want to have something like that as well.

One issue with only allowing it on override is that you can't implement interface methods that way. Doesn't mean it shouldn't be supported though. :)

[Gama11]

Need some kind of support from Haxe for this as well.

[ncannasse]

Up ? :)

[Simn]

HaxeFoundation/haxe#7005

[kevinresol]

Wait, does this address the original issue? (code completion)

[Simn]

No...

[Gama11]

Oh, I knew there was an issue for override generation somewhere.. No wonder I couldn't find it. x)

[Gama11]

This is supported now:

(still a few known issues to work out, but most cases work fine)

[ncannasse]

Can we remove the "public" that is added ? By default, override should not increase the visibility of the method (in case we change it to private later)

[Simn]

It only adds that if the overridden field is public too.

[ncannasse]

It's still unnecessary, and in case the "public" is removed from the original method declaration, it sill allows public access to all overridden methods.

…

On Fri, Jun 8, 2018 at 9:44 AM, Simon Krajewski ***@***.***> wrote: It only adds that if the overridden field is public too. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#92 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-bwAWY3WP4QrnZ_YL7uv9wVf0qt1jqks5t6itOgaJpZM4MN73s> .

[Simn]

Uhm okay, I thought it would be a compiler error if we don't have the public there. That's how it behaves for interfaces, but not for overrides. Isn't that inconsistent?

[kevinresol]

I am used to that behaviour, to me it just mean "inherit the access"

[Gama11]

I don't really like that Haxe feature to begin with... Visibility in classes defaulting to private except for overrides of public methods hurts readability / is confusing, in my opinion.

If there's really a demand for it (which I doubt at the moment), we could add a code style setting for this, but I'd still like public access to be explicit by default. Note that FlashDevelop, which this feature is copied from, adds public as well.

[ncannasse]

override is override : it redefines the method without changing its visibility. regarding interface : implements is implicit since you don't need to tell "implements" on each method, so the visibility needs to match. Please remove the public, that's not because FlashDevelop is doing it wrong that we should follow :D

…

On Fri, Jun 8, 2018 at 9:56 AM, Jens Fischer ***@***.***> wrote: I don't really like that Haxe feature to begin with... Visibility in classes defaulting to private *except for overrides of public methods* hurts readability / is confusing, in my opinion. If there's really a demand for it (which I doubt at the moment), we could add a code style setting for this, but I'd still like public access to be explicit by default. Note that FlashDevelop, which this feature is copied from, adds public as well. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#92 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA-bwHJeCb3ZPBsJFazYJ15r92kYS0pMks5t6i4TgaJpZM4MN73s> .

[Gama11]

I've added explicitPublic and explicitPrivate options, which you can specify like this if you want visibility to always be explicit:

"haxe.codeGeneration": {
    "functions": {
        "field": {
            "explicitPublic": true,
            "explicitPrivate": true
        }
    }
}

explicitPublic - Whether to include the public visibility modifier even if it can be omitted
explicitPrivate - Whether to include the private visibility modifier even if it can be omitted

The default value for both is false.