-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add folding markers to syntax configuration #202
Conversation
Add the region markers `//#region` and `//#endregion` to add custom folding regions.
Well, this is a strange build error... 🤔 |
There was a discussion about this here: #179 |
Oh, sorry for the useless PR then. |
This feature is going to be implemented in IDEA too: HaxeFoundation/intellij-haxe#744 |
IDEA is going to have two flavors available, at first:
Eventually, the user will be allowed to specify starting and ending markers by providing regexes via a dialog. Edit: Oh, yeah. It works with any comment type (single line, block, documentation), if the marker is on the top line of the block, and the two types don't styles don't match each other. |
Maybe we could use a regex as default which matches all the styles at once? The start: The end: Afterwards the pattern could be swapped out by a command or something along this line to use a specific style. Note: There is no Edit: It lacks the |
Is the EDIT: C#, it would appear. Except that it doesn't appear in comments. |
I think the https://github.com/Microsoft/vscode/blob/master/extensions/java/language-configuration.json#L27 |
@nadako Any thoughts on this? |
Not really, but this won't hurt I guess |
Since there's not really a convention, it would be strange to pick out one specific style to support. I'm going to use the @KevinGliewe's "match-all" regexes with support for:
|
This PR adds the region markers
//#region
and//#endregion
to add custom folding regions in the Haxe Code.The snipped for the marker definition comes from the TypeScript configuration file in the VSCode repo:
https://github.com/Microsoft/vscode/blob/master/extensions/typescript/language-configuration.json#L28
I hope you guys like this feature.