Fix wrong timeRange for cloudscale.ch bucket metrics #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudscale.ch counts the day from midnight to midnight in the Europe/Zurich timezone (see: https://github.com/cloudscale-ch/cloudscale-go-sdk/blob/v2.1.0/metrics.go#L15-L19) However, we for us in odoo the day is from midnight to midnight in UTC. We therefore can't use the Start and End times provided in the resulting metric, but instead set it ourselves, to the correct midnight time of UTC for the desired day. Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
tobru
approved these changes
Jan 23, 2024
Kidswiss
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudscale.ch counts the day from midnight to midnight in the Europe/Zurich timezone (see: https://github.com/cloudscale-ch/cloudscale-go-sdk/blob/v2.1.0/metrics.go#L15-L19) However, we for us in odoo the day is from
midnight to midnight in UTC.
We therefore can't use the Start and End times provided in the resulting metric, but instead set it ourselves, to the correct midnight time of UTC for the desired day.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.