Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e-test framework #10

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix e2e-test framework #10

merged 1 commit into from
Aug 28, 2023

Conversation

Kidswiss
Copy link
Collaborator

@Kidswiss Kidswiss commented Aug 25, 2023 •
edited

Summary

  • Some fixes to make the e2e-test work

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss added the bug Something isn't working label Aug 25, 2023
zugao
zugao reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing

package/crossplane.yaml Show resolved Hide resolved
@Kidswiss Kidswiss requested a review from zugao August 25, 2023 12:23
zugao
zugao approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kidswiss Kidswiss merged commit 062f763 into master Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee

@wejdross wejdross Awaiting requested review from wejdross

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kidswiss @zugao