Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy management #20

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Add policy management #20

merged 2 commits into from
Sep 5, 2023

Conversation

Kidswiss
Copy link
Collaborator

@Kidswiss Kidswiss commented Sep 4, 2023

Summary

It's now possible to manage policies via the provider. A policy can take one of two config options:

  • AllowedBucket: It will create a pre-defined policy to allow everything
    on that given bucket
  • RawPolicy: It will take a JSON string with the given policy and create
    the policy accordingly in minio

It's also possible to add policies to users. There's a webhook that will check beforehand if the policy actually exists or not.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@Kidswiss Kidswiss marked this pull request as draft September 4, 2023 09:09
@Kidswiss Kidswiss changed the title Add policy controller Add policy management Sep 4, 2023
@Kidswiss Kidswiss added the enhancement New feature or request label Sep 4, 2023
@Kidswiss Kidswiss force-pushed the add/policy branch 5 times, most recently from f6f0e83 to 5facb6a Compare September 4, 2023 12:53
@Kidswiss Kidswiss marked this pull request as ready for review September 4, 2023 13:06
@Kidswiss Kidswiss requested review from a team, wejdross, zugao and TheBigLee and removed request for a team September 4, 2023 13:09
It's now possible to manage policies via the provider. A policy can take
one of two config options:

* AllowedBucket: It will create a pre-defined policy to allow everything
  on that given bucket
* RawPolicy: It will take a JSON string with the given policy and create
  the policy accordingly in minio

It's also possible to add policies to users. There's a webhook that will
check beforehand if the policy actually exists or not.
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kidswiss Kidswiss merged commit b10fbca into master Sep 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants