feat: add bucket policy #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kidswiss any update on this? |
|
|
|
@raffis Sorry didn't notice the PR here, as I was not added as a reviewer. |
No worries. You might want to consider adding a CODEOWNERS for auto review assignment. |
Kidswiss
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently I am not seeing a way of setting a bucket policy (not a user policy).
This pr extends
Bucketwith an optionalpolicyfield.Note: Alternatively a separate Resource called
BucketPolicymight be introduced similar to to the aws provider. However since user polices are also directly linked and not utilizing a resource likeUserPolicyAttachementas the aws provider provides it I opted for fhe direct field here too. But I leave that up to you to decide...Checklist
enhancement