Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GPS functions #34

Closed
wants to merge 7 commits into from
Closed

add GPS functions #34

wants to merge 7 commits into from

Conversation

brvdg
Copy link
Contributor

@brvdg brvdg commented May 9, 2017

Adding some GPS functions for SIM808

@vshymanskyy
Copy link
Owner

Could we create a separate SIM808 class and subclass from SIM800?
Just to make better context for the function availability...

@vshymanskyy
Copy link
Owner

Also,take a look at this PR: #15
This is similar, and provides example - maybe we can merge them...

@brvdg
Copy link
Contributor Author

brvdg commented May 10, 2017

This idea sounds good.
But at the moment I have no idea how to create a library which use functions from the sim800 lib.
Or should I made a hole new lib which don't use the sim800 lib?

brvdg added 3 commits June 1, 2017 17:29
@brvdg
create sim808
ff5424c
@brvdg
Merge branch 'master' of https://github.com/brvdg/TinyGSM
27ea61a 
Conflicts:
	TinyGsmClient.h
	TinyGsmClientSIM800.h
@brvdg
rename sim808 tosim808v2
f6e228b 
SIM808 has two different models with different AT commands for the GPS
function.
@brvdg
Copy link
Contributor Author

brvdg commented Jun 1, 2017

I created separate file for a SIM808 Module. But it's work only wit the version 2. The SIM808 V1 has different AT commands for GPS.

@vshymanskyy
Copy link
Owner

@brvdg Let me invite you to or new TinyGSM developer chat:
https://gitter.im/tinygsm/Developers?utm_source=share-link&utm_medium=link&utm_campaign=share-link

@brvdg
Copy link
Contributor Author

brvdg commented Sep 12, 2017

closing this and reopen a new one which is based on newer code.

@brvdg brvdg closed this Sep 12, 2017
SRGDamia1 added a commit that referenced this pull request Mar 2, 2020
@SRGDamia1
Merge pull request #34 from adrianca88/add_getIMSI_SIM800
7adf85d 
Add get imsi sim800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brvdg @vshymanskyy