Dtb 20160827

[DanielTBrown]

Fix handling of MSVSVER variable to avoid undefined variable error.

For Microsoft Windows builds, replace calls to gclient.bat with calls to python src/webrtc/build/gyp_webrtc.py, consistent with other platforms. This also eliminates the undefined variable $WIN_DEPOT_TOOLS.

[vsimon]

Looks great to me, merging with thanks.

[agouaillard]

I think that runhooks still needs to be run, just the project generation step has been removed from it and made into its own step because of the transition between GYP and GN. See discuss-webrtc mailing list PSA from henrik for reference.

Sent from my iPhone

On 28 Aug 2016, at 23:15, DanielTBrown notifications@github.com wrote:

Fix handling of MSVSVER variable to avoid undefined variable error.

For Microsoft Windows builds, replace calls to gclient.bat with calls to python src/webrtc/build/gyp_webrtc.py, consistent with other platforms. This also eliminates the undefined variable $WIN_DEPOT_TOOLS.

You can view, comment on, or merge this pull request online at:

#18

Commit Summary

Fix error in Microsoft Visual Studio version handling
Merge branch 'master' into DTB-20160827
Merge branch 'master' into DTB-20160827
File Changes

M build.sh (3)
M util.sh (4)
Patch Links:

https://github.com/vsimon/webrtcbuilds/pull/18.patch
https://github.com/vsimon/webrtcbuilds/pull/18.diff
―
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.