Skip to content

Commit

Permalink
fix: ignore .ssh pub keys (runfinch#109)
Browse files Browse the repository at this point in the history
Signed-off-by: Justin Alvarez <alvajus@amazon.com>

Issue #, if available: Fixes runfinch#103. Still having trouble reproducing #38,
but possibly related

*Description of changes:*
- Our Lima configuration (finch.yaml) was using the default value for
the `ssh.loadDotSSHPubKeys` option, which is `true`. This may cause
errors if the user has any issues with the keys in their `.ssh`
directory. Since the correct key is generated and stored in Lima's
directories, and the user is not expected to interact directly with the
VM anyway, we can just set this to `false` explicitly
- In the future, we can consider adding this to finch's config (probably
by adding logic to `pkg/config`'s `lima_config_applier` and
`defaults.go`)

*Testing done:*
- Reproduced the error by creating an invalid pub key entry. Made the
change to my local `lima.yaml` and rebooted the vm, and did not see the
error


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
  • Loading branch information
pendo324 committed Dec 12, 2022
1 parent 934521c commit 0b74597
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion finch.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ ssh:
# applications such as rsync with the Lima instance.
# If you have an insecure key under ~/.ssh, do not use this option.
# 🟢 Builtin default: true
loadDotSSHPubKeys: null
loadDotSSHPubKeys: false
# Forward ssh agent into the instance.
# 🟢 Builtin default: false
forwardAgent: null
Expand Down

0 comments on commit 0b74597

Please sign in to comment.