Skip to content

Commit

Permalink
[Bug 611564] [NEW] sparkle fails to build with clang due to -Werror.\…
Browse files Browse the repository at this point in the history
…n\nAlso, switching to Clang because hoorah.
  • Loading branch information
andymatuschak committed Jul 31, 2010
1 parent a5c8e0b commit b7a3999
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Configurations/ConfigCommon.xcconfig
Expand Up @@ -16,6 +16,7 @@ GCC_PREFIX_HEADER = $(SDKROOT)/System/Library/Frameworks/Cocoa.framework/Headers
GCC_FAST_OBJC_DISPATCH = YES
GCC_ENABLE_PASCAL_STRINGS = NO
ARCHS = ppc i386 x86_64
GCC_VERSION = com.apple.compilers.llvm.clang.1_0

// Enable warnings
GCC_WARN_CHECK_SWITCH_STATEMENTS = YES
Expand Down Expand Up @@ -46,4 +47,4 @@ GCC_WARN_UNUSED_VALUE = YES
GCC_WARN_UNUSED_PARAMETER = YES
GCC_WARN_ABOUT_MISSING_FIELD_INITIALIZERS = YES
GCC_WARN_UNDECLARED_SELECTOR = YES
WARNING_CFLAGS = -Wall -Wundef -Wendif-labels -Wpointer-arith -Wcast-align -Wwrite-strings -Wmissing-noreturn -Wmissing-format-attribute -Wpacked -Wredundant-decls -Winline -Wdisabled-optimization -Wformat=2 -Wlarger-than-32768 -Winvalid-pch
WARNING_CFLAGS = -Wall -Wno-unused-parameter -Werror -Wundef -Wendif-labels -Wpointer-arith -Wcast-align -Wwrite-strings -Wmissing-format-attribute -Wpacked -Wredundant-decls -Winline -Wdisabled-optimization -Wformat=2 -Winvalid-pch
2 changes: 1 addition & 1 deletion SUBinaryDeltaCommon.m
Expand Up @@ -60,7 +60,7 @@ static void _hashOfFile(unsigned char* hash, FTSENT *ent)
{
if (ent->fts_info == FTS_SL) {
char linkDestination[MAXPATHLEN + 1];
size_t linkDestinationLength = readlink(ent->fts_path, linkDestination, MAXPATHLEN);
ssize_t linkDestinationLength = readlink(ent->fts_path, linkDestination, MAXPATHLEN);
if (linkDestinationLength < 0) {
perror("readlink");
return;
Expand Down

0 comments on commit b7a3999

Please sign in to comment.