Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous source text should be shown near current source text #556

Open
rillig opened this issue Apr 1, 2019 · 2 comments
Open

Previous source text should be shown near current source text #556

rillig opened this issue Apr 1, 2019 · 2 comments

Comments

@rillig
Copy link

rillig commented Apr 1, 2019

image

The previous source text is shown to the right. It is placed far away from the current source text, which makes it difficult to compare the two versions of the text. In this case they differ by a single dot at the end.

Placing the previous source text directly above the current source text would make this comparison as easy as it should be. To distinguish it from the current source text, it should have a different background color. Like this:

image

It might even be useful to highlight the difference between the previous and the current text. A very simple approach is to determine the longest common prefix, determine the longest common suffix, and then color everything in between using a different background. It's better than the current state and much easier to implement that a full diff. Although wdiff already exists.

@vslavik
Copy link
Owner

vslavik commented Apr 2, 2019

First of, I agree this is a usability issue. Some comments about your proposed fix, though:

Placing the previous source text directly above the current source text would make this comparison as easy as it should be.

…at the cost of eating precious space (which needs to be somehow reasonably allocated even for entries without previous msgid, or expanded dynamically).

To distinguish it from the current source text, it should have a different background color. Like this:

That's far too little to make it understandable, even to people familiar with the concept.

It might even be useful to highlight the difference between the previous and the current text.

See #230.

I think showing the diff nicely addresses the "I can't spot the difference" accessibility issue (which I don't dispute) better than putting them together like this, doesn't it?

Or to rephrase, #230 is definitely needed; of this layout change I am not yet sure.

@rillig
Copy link
Author

rillig commented Apr 2, 2019

I would be happy if #230 were implemented, so you may close this issue if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants