New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internet Explorer won't be supported for long #227
Comments
Sure, if somebody contributes such code, while preserving compatibility with older Windows versions. Perhaps — seeing how you're affected, use WinSparkle commercially and have "we" kind of manpower — you could be the one that contributes the PR? At the very least please provide full, detailed reproduction instructions (incl. precise versions of Windows etc., steps to see in WinSparkle example or required patches etc.), because contrary to the implicit assumption, this is not something that just shows for everybody on up-to-date Windows 10. Thanks in advance! |
Note to self: wxWidgets (the UI library we use) now has code for this, including static linking, so we'll get the upgrade almost for free by updating to wx-3.1.7 |
Microsoft did drop support for MS Internet Explorer. When you click on a link in the 'Release notes' window a new (IE) window is launched with a 'Internet Explorer 11 is now out of support' message. So MS IE is nobodies default browser anymore, resulting in a WTF response from users. Ideally the user's default browser is launched (Chrome, Firefox, ...). Second best would be to switch to Edge. Anyway the use of unsupported software should be stopped; please update this. |
Maybe reserve that phrasing for people you actually do have a consulting contract with... Why don't you submit a PR? That would help a lot, unlike this sort of "me too" comments. |
Your comment on 9 June gave me the impression that you already investigated this and that it is a relative easy fix. If I have misunderstood this then I am sorry. For me, before I can think of a PR, I'll need to deep dive into the source and understand how it is supposed to work. That will take some time. |
A major upgrade of the GUI toolkit is not particularly hard, but it's far from easy.
WinSparkle doesn't use MSIE. It uses the WebBrowser control, which remains part of the Windows API. It does sound like you hijacked this issue for something unrelated: that clicking links, which don't open inline (see #177), doesn't use user's browser. If I understand you correctly, that's a separate issue from this one. |
Hi vslavik, I do think it is related. The WebBrowser control does, as the name suggests, launch a browser in embedded mode. If I understand correctly the WebBrowser control is used in src\ui.cpp line 1000 UpdateDialog::ShowReleaseNotes, with the comment “Load MSIE control” on line 1004. Regarding using the users default browser instead of Edge; it looks like that is very hard to do. It’s more like a nice-to-have feature for me. PS: When compiling using WinSparkle.sln I get currently stuck at “packages\Gettext.Tools.0.20.2\tools\bin\msgfmt.exe not found” error. |
(Loosely) related doesn't mean same issue. Thanks for the incompetence-assuming lecture, but it is misplaced. If you're willing to submit a PR, please do. Otherwise this is just wasting time of both of us. Both of the issues are tracked, I'm aware of them.
It's literally the one thing you complained about. You attached a screenshot of MSIE being opened, not of an issue with the embedded release notes viewer.
Don't. One issue, one thing. You're making a mess. |
Update WinSparkle to a version which includes wxWidgets 3.2.1, which fixes vslavik/winsparkle#227. Fixes #18488.
Hello,
Is it possible to switch from IE rendering to Edge Chromium?
We are getting this warning now:
The text was updated successfully, but these errors were encountered: