Clicking "Enter" on "Install" button in update window causes installer redownload instead of running setup

[kjen93]

Steps to reproduce:
In "Updates avaliable" window click "Install".
After download finishes, use "Enter" to click "Install" button instead of using mouse,
After you press "Enter" Winsparkle starts download again.
Here is the video of this bug http://www.youtube.com/watch?v=5ydRRwO221c&feature=youtu.be

[vslavik]

What version of Windows are you using? Here (Win 8.1), pressing Enter does nothing (which too is wrong, of course)...

[kjen93]

I am using Windows 7 Pro SP1 in the video, but this bug was found by our app user on Windows 8.1 Update 1 Pro.

[vslavik]

Hmm, so clearly the description is not as reproducible as I thought, because it simply doesn't behave as described here. Could you clarify which uses of "click" in your description really mean click (i.e. with mouse) and which are other ways of pressing the button? For me, it looks like keyboard handling is just broken generally…

Also, you are using the latest master sources and verified it wasn't fixed since then, right?

[kjen93]

I am using latest master sources with only change that they were localized to Russian language for our app. I've tried to reproduce it with example app, which goes with library, and the bug is present even there. Every time I press "Enter" on my keyboard in that window, I see progress bar for update redownloading (or refetching from cache). When I use mouse to click it, it works ok.

Now I am going to rebuild WxWidgets and Winsparkle from unmodified sources and check, if the bug remains. I'll post an additional comment when I'll have any results.

[kjen93]

I am sorry, it really just does nothing in latest unmodified sources. I am sorry for this, but I think this is still a bug.

[vslavik]

but I think this is still a bug.

“This” being that pressing Enter does nothing because the buttons seem to loose focus (or TAB navigation for that matter)? Yes, very much so :-(