Added possibility to use alternate download locations (sparkle:os attribute) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, that was fast, thank you! However, do you think you could reformat your changes to use 4 spaces instead of tabs, as the rest of the sources (see the diff for what mixing them did to readability)? No other comments except these nitpicks, looks great to me otherwise. TIA! |
|
Yeah, sure, but maybe tomorrow? 2014/1/23 Václav Slavík notifications@github.com
|
fixed tabs, added parsing break in OnEndElement()
vslavik
added a commit
that referenced
this pull request
Jan 27, 2014
Add sparkle:os attribute support for multi-platform feeds.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to use alternate download locations in different operating systems
by specifying sparkle:os attribute in appcast.xml file.
Appcast.xml can contain one for Mac OS X
and one with <enclosure sparkle:os="windows" ...> for Windows.
If no sparkle:os="windows" attribute found, the first is used as usual.