Fix InsiderTransactionResponse TransactionShares #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vslee
approved these changes
Apr 28, 2022
|
Thanks for your contribution! It is now incorporated into the latest pre-release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InsiderTransactionResponse defines fields TransactionShares, TranShares and PostShares as a nullable long, but IEX sometimes returns it with decimals causing a Json deserialization exception.
Example response from IEX for symbol DIS.
TransactionShares: 595.2000122070312
Exception:
System.Text.Json: The JSON value could not be converted to System.Nullable`1[System.Int64]. Path: $[0].transactionShares | LineNumber: 0 | BytePositionInLine: 321. System.Text.Json.Rethrowable: Either the JSON value is not in a supported format, or is out of bounds for an Int64.
IEX docs define it as type 'number'.
This PR changes them to nullable decimal to fix #123