Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stock missing fields #87

Merged
merged 14 commits into from Dec 13, 2020

Conversation

@JamiePrentice
Copy link
Collaborator Author

Will expand on this. Premature PR. Don't merge yet.

@vslee vslee added the enhancement New feature or request label Dec 12, 2020
@JamiePrentice
Copy link
Collaborator Author

With this expansion of fields, looking at https://iexcloud.io/docs/api/#income-statement and IncomeStatementResponse.cs

I'm wondering if it would be safest here to make the majority of the values nullable. Curious about the consensis on this.

@JamiePrentice
Copy link
Collaborator Author

public string id { get; set; } 
public string key { get; set; } 
public string subkey { get; set; } 
public long updated { get; set; } 

Seem to have been added to a lot of the responses, it might be worth looking at a base response that includes these.

@JamiePrentice
Copy link
Collaborator Author

There appears to be duplicate fields on Insider-Transactions.

https://iexcloud.io/docs/api/#insider-transactions

The descriptions of these data points are the same in the API docs, however they appear to be returning different values. This could be down to the fuzzing of data on the test API response however.

image

@JamiePrentice JamiePrentice self-assigned this Dec 13, 2020
- Removing fields that are no longer in use as of 01/12/2020.
- Adding missing beta field.
+ Rearrange to match IEX Docs.
@JamiePrentice
Copy link
Collaborator Author

JamiePrentice commented Dec 13, 2020

Ready for review.

These are the updates for under the https://iexcloud.io/docs/api/#stocks-equities section.

Not including

@vslee
Copy link
Owner

vslee commented Dec 13, 2020

With this expansion of fields, looking at https://iexcloud.io/docs/api/#income-statement and IncomeStatementResponse.cs

I'm wondering if it would be safest here to make the majority of the values nullable. Curious about the consensis on this.

Ya, I think that would be the safest too.

public string id { get; set; } 
public string key { get; set; } 
public string subkey { get; set; } 
public long updated { get; set; } 

Seem to have been added to a lot of the responses, it might be worth looking at a base response that includes these.

Sounds good to me

There appears to be duplicate fields on Insider-Transactions.

https://iexcloud.io/docs/api/#insider-transactions

The descriptions of these data points are the same in the API docs, however they appear to be returning different values. This could be down to the fuzzing of data on the test API response however.

image

You're right, I think it's just the obfuscation they're doing on the sandbox data.

@vslee vslee merged commit 4a0ddef into vslee:main Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants