-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use long on volume properties #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for the fix @rinukkusu! |
Thanks for pulling in the changes, but how do I use the pre-release packages from GitHub's package repository? |
You could do what's listed on the packages page here: https://github.com/vslee/IEXSharp/packages/62376 Until the next Nuget release. |
I have now released v2.6.0 which includes your fix. But if you do have a chance, please give the pre-release a try as I would like to know if people are having any issues with it. |
@JamiePrentice @vslee I've tried that already with no success, will check it out in depth tomorrow - thanks a lot!! 😄 |
Try these instructions. If they work for you, I'll link to them from the front page. |
Ahhh, I was using my own account, but I had to use your token - makes sense now 😄 Using it with my CI/CD: https://gitlab.com/rinukkusu/telly/-/commit/678cbce30171211316ae42ccae23f682cfc62d5a |
Great, glad it worked and looks like you figured out how to put it into your NuGet.config. |
Trying to get a stock quote for $HCMC throws an exception. Digging deeper it seems the
previousVolume
property can't handle volumes larger thanint32
:Response from IEX Cloud
My attempt on fixing that: use
long?
for all volume-related properties in theQuote
class.