Skip to content

Commit

Permalink
remove direction from base type
Browse files Browse the repository at this point in the history
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
  • Loading branch information
vsoch committed Jul 5, 2022
1 parent 89c22b1 commit f526ee3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 6 additions & 4 deletions README-SMEAGLE.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,12 @@ These are cases with gcc 12.1 dwarf and the library here that I can't resolve. I


## TODO:

- Add Void as a type (void pointers)
- Vanessasaurus: Redo parse_location to update entire entry
- Add to tests:
- what happens if you pass an unnamed reference or pointer - does dwarf say it gets space or?
- Need:
- representation for functions that take no parameter and return nothing (Void)
- empty structures: just don't represent them.
-
- Tim:
- Write out high level approach
- need to complement this with C++ interface to get callsites into Python. Only need for callsites for now, unless speed is an issue in the future.
Expand All @@ -130,7 +133,6 @@ These are cases with gcc 12.1 dwarf and the library here that I can't resolve. I
- we haven't handled parsing any kind of vectors (greater than size 128, etc) needs an eightbyte approach
- we need to add / parse [fortran types](https://docs.oracle.com/cd/E19957-01/805-4939/6j4m0vn6m/index.html) right now just Unknown
- return type allocator does not correctly handle struct/union
- empty structures
- void pointers don't seem to show up in dwarf with global variables, without they do.
- `__ARRAY_SIZE_TYPE__` and `sizetype` in types.py
- look at hpctoolkit libs to find example that suggests loading with blob - some kind of wrapped dwarf?
Expand Down
2 changes: 0 additions & 2 deletions cle/backends/elf/corpus.py
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,6 @@ def parse_string_type(self, die, flags=None):
"type": "char",
"size": self.get_size(die),
"class": self.add_class(die),
"direction": "import",
}
entry = self.add_flags(entry, flags)
return entry
Expand All @@ -564,7 +563,6 @@ def parse_base_type(self, die, flags=None):
"type": self.get_name(die),
"size": self.get_size(die),
"class": self.add_class(die),
"direction": "import",
}
entry = self.add_flags(entry, flags)
return entry
Expand Down

0 comments on commit f526ee3

Please sign in to comment.