Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple first-level sidebar headings #46

Merged
merged 2 commits into from
Jul 17, 2021
Merged

Added support for multiple first-level sidebar headings #46

merged 2 commits into from
Jul 17, 2021

Conversation

kieran-mackle
Copy link
Contributor

I tidied the sidebar.html code a bit and made it so that you can have multiple first-level sidebar headings.

@vsoch
Copy link
Owner

vsoch commented Jul 16, 2021

We've had multiple requests for this:

And I've pushed back because it doesn't technically match the docsy theme. But since you've done the work, let's review it! If it's a better design I'm okay with the change. I'll ping the requests on the issues above:

@gregdegruy, @elenalenaelena, @leecalcote, you've all expressed interest in having multiple levels for the menu. Would you care the review the PR here?

@vsoch
Copy link
Owner

vsoch commented Jul 16, 2021

And I’ll make some time to review tomorrow. Stay tuned! :)

@kieran-mackle
Copy link
Contributor Author

I understand! I just did it for my own site so thought I would share. I am quite new to html but it looked as though there were some missing closing tags in the for loops. Adding them resulted in the behaviour I expected after adding items to toc.yml.
Thanks for reviewing!

@vsoch
Copy link
Owner

vsoch commented Jul 16, 2021

@kieran-mackle so just to verify what I'm seeing (the changes) - the sidebar stays open when you click a link? I don't see another level of nesting (e.g., for the current site if I add another level of children it doesn't show up:

      children:
        - title: Quizzes
          url: "docs/extras/example-quiz"
          children:
          - title: Tags Page
            url: "tags"

Let me know how to reproduce what you changed so I can see (and let me know if it's just that the sidebar stays open, which is very good!)

@vsoch
Copy link
Owner

vsoch commented Jul 16, 2021

Oh I think I see - multiple bolded levels?

image

This looks great to me - let's give the others a few days to look and review and I definitely think this would be great to have!

@kieran-mackle
Copy link
Contributor Author

Yes that's correct, the multiple first-level bold headings. Glad you like it!

@vsoch
Copy link
Owner

vsoch commented Jul 17, 2021

I'm going to say let's go ahead with integrating this change - it's indeed very useful and nice looking. The final TODOs for the PR are to:

  • bump the version up to 0.0.23 in the root VERSION file
  • Add a note to the CHANGELOG to indicate the changes here

And then we can merge and release!

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch vsoch merged commit a3e309e into vsoch:master Jul 17, 2021
@vsoch
Copy link
Owner

vsoch commented Jul 17, 2021

Thank you again @kieran-mackle ! I tweeted your work as a thank you, feel free to share! https://twitter.com/vsoch/status/1416506158471282688

@kieran-mackle
Copy link
Contributor Author

No worries! Glad you like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants