-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for multiple first-level sidebar headings #46
Conversation
We've had multiple requests for this:
And I've pushed back because it doesn't technically match the docsy theme. But since you've done the work, let's review it! If it's a better design I'm okay with the change. I'll ping the requests on the issues above: @gregdegruy, @elenalenaelena, @leecalcote, you've all expressed interest in having multiple levels for the menu. Would you care the review the PR here? |
And I’ll make some time to review tomorrow. Stay tuned! :) |
I understand! I just did it for my own site so thought I would share. I am quite new to html but it looked as though there were some missing closing tags in the for loops. Adding them resulted in the behaviour I expected after adding items to toc.yml. |
@kieran-mackle so just to verify what I'm seeing (the changes) - the sidebar stays open when you click a link? I don't see another level of nesting (e.g., for the current site if I add another level of children it doesn't show up: children:
- title: Quizzes
url: "docs/extras/example-quiz"
children:
- title: Tags Page
url: "tags" Let me know how to reproduce what you changed so I can see (and let me know if it's just that the sidebar stays open, which is very good!) |
Yes that's correct, the multiple first-level bold headings. Glad you like it! |
I'm going to say let's go ahead with integrating this change - it's indeed very useful and nice looking. The final TODOs for the PR are to:
And then we can merge and release! |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Thank you again @kieran-mackle ! I tweeted your work as a thank you, feel free to share! https://twitter.com/vsoch/status/1416506158471282688 |
No worries! Glad you like it! |
I tidied the sidebar.html code a bit and made it so that you can have multiple first-level sidebar headings.