Skip to content

Commit

Permalink
Automated deployment to update contributors 2020-10-29 (#73)
Browse files Browse the repository at this point in the history
Co-authored-by: github-actions <github-actions@users.noreply.github.com>
  • Loading branch information
github-actions[bot] and github-actions committed Oct 29, 2020
1 parent 547f4dd commit 8b952f0
Show file tree
Hide file tree
Showing 7 changed files with 103 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
event_type: IssueCommentEvent
avatar: "https://avatars.githubusercontent.com/u/814322?"
user: vsoch
date: 2020-10-28
repo_name: datalad/datalad-container
html_url: https://github.com/datalad/datalad-container/issues/98
repo_url: https://github.com/datalad/datalad-container
---

<a href='https://github.com/vsoch' target='_blank'>vsoch</a> commented on issue <a href='https://github.com/datalad/datalad-container/issues/98' target='_blank'>datalad/datalad-container#98</a>.

<small>I think it would be cleaner to go directly from the Registry API, and then retrieve the exact downloads for the layers and config, which already come with the digests. As I understand docker save, it's going to write on the fly, which means new timestamps and thus new hashes. It would be confusing for the user to see a known image locally (e.g., busybox:vX.X.X) and then not see digests that line up with what is on Docker Hub (or another registry). The benefit of not using docker save is that docker does not become a dependency for datalad. It's also messy to have "the same" layers that appear different because of different timestamps....</small>

<a href='https://github.com/datalad/datalad-container/issues/98' target='_blank'>View Comment</a>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
event_type: IssueCommentEvent
avatar: "https://avatars.githubusercontent.com/u/814322?"
user: vsoch
date: 2020-10-28
repo_name: expfactory-experiments/kirby
html_url: https://github.com/expfactory-experiments/kirby/issues/1
repo_url: https://github.com/expfactory-experiments/kirby
---

<a href='https://github.com/vsoch' target='_blank'>vsoch</a> commented on issue <a href='https://github.com/expfactory-experiments/kirby/issues/1' target='_blank'>expfactory-experiments/kirby#1</a>.

<small>Hey @tfeige91 ! Let's start with the issue in the browser. I tested for Firefox (no errors in the console) and then Chrome (I reproduced your issues) and for the latter, regardless of the error it seemed to function without issue. So, a first option is just to use Firefox, or be okay with having the messages in the console with Chrome. If you want to take a shot at fixing chrome, likely we just need to try following the instructions and reloading the audio context (see here https://developers.google.com/web/updates/2017/09/autoplay-policy-changes#webaudio) but then you'd need to check for the browser being used and make sure it's chrome. The last errors appear to be missing .map files, which could easily be added to the repository! Do you want to try some of these out and do a PR to the repository? I'd be happy to add any fixes....</small>

<a href='https://github.com/expfactory-experiments/kirby/issues/1' target='_blank'>View Comment</a>
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
event_type: IssueCommentEvent
avatar: "https://avatars.githubusercontent.com/u/814322?"
user: vsoch
date: 2020-10-28
repo_name: fair-software/howfairis
html_url: https://github.com/fair-software/howfairis/issues/47
repo_url: https://github.com/fair-software/howfairis
---

<a href='https://github.com/vsoch' target='_blank'>vsoch</a> commented on issue <a href='https://github.com/fair-software/howfairis/issues/47' target='_blank'>fair-software/howfairis#47</a>.

<small>The use case that I have in mind is this one https://rseng.github.io/rseng/software/howfairis#why-is-it-useful, or any general need to import and run the function (and the sys.exit is unexpected). If you need the client to exit for [these tests](https://github.com/fair-software/howfairis/blob/master/clitests/script.sh). For the non zero exits, it would be okay to exit there (some raise errors and pass up to calling function, but an exit isn't a crazy idea). But for [this exit](https://github.com/fair-software/howfairis/blob/master/howfairis/cli.py#L46) where the client is successful, it would kill two birds with one stone to put it [here](https://github.com/fair-software/howfairis/blob/master/howfairis/cli.py#L107), that way the exit happens for the client but the function is usable outside of it....</small>

<a href='https://github.com/fair-software/howfairis/issues/47' target='_blank'>View Comment</a>
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
event_type: PullRequestReviewCommentEvent
avatar: "https://avatars.githubusercontent.com/u/814322?"
user: vsoch
date: 2020-10-28
repo_name: singularityhub/singularity-python
html_url: https://github.com/singularityhub/singularity-python/pull/100#discussion_r513794979
repo_url: https://github.com/singularityhub/singularity-python
---

<a href='https://github.com/vsoch' target='_blank'>vsoch</a> <a href='https://github.com/singularityhub/singularity-python/pull/100#discussion_r513794979' target='_blank'>commented</a> on <a href='https://github.com/singularityhub/singularity-python' target='_blank'>singularityhub/singularity-python</a>

<a href='https://github.com/singularityhub/singularity-python/pull/100#discussion_r513794979' target='_blank'>View Comment</a>
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
event_type: IssuesEvent
avatar: "https://avatars.githubusercontent.com/u/814322?"
user: vsoch
date: 2020-10-28
repo_name: vsoch/django-oci
html_url: https://github.com/vsoch/django-oci/issues/23
repo_url: https://github.com/vsoch/django-oci
---

<a href='https://github.com/vsoch' target='_blank'>vsoch</a> open issue <a href='https://github.com/vsoch/django-oci/issues/23' target='_blank'>vsoch/django-oci#23</a>.

<p>Add API interfaces to documentation</p><small>Rest framework has several nice interfaces that we should add to documentation - I'm thinking an interfaces page that will share content with #11....</small><a href='https://github.com/vsoch/django-oci/issues/23' target='_blank'>View Comment</a>
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
event_type: PushEvent
avatar: "https://avatars.githubusercontent.com/u/814322?"
user: vsoch
date: 2020-10-28
repo_name: vsoch/opensource-heartbeat
html_url: https://github.com/vsoch/opensource-heartbeat/commit/547f4dd1bbd5f40267a24098c45ba874551f350d
repo_url: https://github.com/vsoch/opensource-heartbeat
---

<a href='https://github.com/vsoch' target='_blank'>vsoch</a> pushed to <a href='https://github.com/vsoch/opensource-heartbeat' target='_blank'>vsoch/opensource-heartbeat</a>

<small>Automated deployment to update contributors 2020-10-28 (#72)

Co-authored-by: github-actions <github-actions@users.noreply.github.com></small>

<a href='https://github.com/vsoch/opensource-heartbeat/commit/547f4dd1bbd5f40267a24098c45ba874551f350d' target='_blank'>View Commit</a>
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
event_type: PushEvent
avatar: "https://avatars.githubusercontent.com/u/814322?"
user: vsoch
date: 2020-10-29
repo_name: singularityhub/sregistry
html_url: https://github.com/singularityhub/sregistry/commit/0c88404338720811f85e74da579e1b05d997a1c9
repo_url: https://github.com/singularityhub/sregistry
---

<a href='https://github.com/vsoch' target='_blank'>vsoch</a> pushed to <a href='https://github.com/singularityhub/sregistry' target='_blank'>singularityhub/sregistry</a>

<small>typos (#327)</small>

<a href='https://github.com/singularityhub/sregistry/commit/0c88404338720811f85e74da579e1b05d997a1c9' target='_blank'>View Commit</a>

0 comments on commit 8b952f0

Please sign in to comment.