-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding message to run/rerun, other interface tweaks #32
Conversation
…nd print of host/port to terminal on qme start Signed-off-by: vsoch <vsochat@stanford.edu>
Signed-off-by: vsoch <vsochat@stanford.edu>
@yarikoptic please review! I tried to just add you as a reviewer to the repo but it didn't give me the option, I suppose I forgot how to do that :P |
Signed-off-by: vsoch <vsochat@stanford.edu>
Just added |
Invite me as a collaborator |
Consider using common prefix for all env var related to logging, eg shorter |
Good idea @yarikoptic, but we can add that in a separate PR when there is some refactor of the logger (out of scope here). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, which might be irrelevant but might be addressed for perfection ;-)
Signed-off-by: vsoch <vsochat@stanford.edu>
@yarikoptic ready again for review! For the logging I can do that in another PR. |
Left a follow up question to one comment which you marked resolved |
Signed-off-by: vsoch <vsochat@stanford.edu>
Sorry that I missed the bit about the host - it's added now! :) |
Sorry to be the pain and not properly describing my intentions, I should have had add a suggestion but ATM hard on the phone. Before using host variable, don't you need to move it's final definition there? (And use also below), ie host=host or QME_HOSTNAME |
Signed-off-by: vsoch <vsochat@stanford.edu>
Oversight on my part - fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Cheers
Signed-off-by: vsoch <vsochat@stanford.edu>
This pull request will address the following issues: