Testing spackbot for a branch that needs an isort fix #15
Conversation
|
@spackbot HELLO |
|
👋️ |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
I was able to run ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. |
|
It looks like you had an issue with style checks! To fix this, you can run: $ spack style --fixAnd then update the pull request here. Or you can just say |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
Here is the output from ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
==> Running isort checks
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
Here is the output from ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/url.py
==> Running isort checks
Fixing /tmp/tmp52p50mjy/spack/lib/spack/spack/url.py
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. But it looks like I'm not able to push to your branch. 😭️ |
|
@spackbot fix style ! |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
Here is the output from ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/url.py
==> Running isort checks
Fixing /tmp/tmpa1fel0md/spack/lib/spack/spack/url.py
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot check style! |
|
@spackbot check style |
|
@spackbot r u ded |
|
@spackbot check style |
|
@spackbot hello! |
|
Hello! |
|
@spackbot fix style yes I'm stupid. |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
@spackbot fix style |
|
Let me see if I can fix that for you! This might take a moment... |
|
Here is the output from ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/url.py
==> Running isort checks
Fixing /tmp/tmp3faklf3z/spack/lib/spack/spack/url.py
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. |
1 similar comment
|
Here is the output from ==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/url.py
==> Running isort checks
Fixing /tmp/tmp3faklf3z/spack/lib/spack/spack/url.py
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. |
|
@vsoch what happens if the output gets long? |
|
I don't think POST has any limit on the size of data, so I suspect it would just put all the output. |
|
We could put a details instead, but then it's an extra click. spack style --fix==> Running style checks on spack:
selected: isort, mypy, flake8
==> Modified files:
lib/spack/spack/url.py
==> Running isort checks
Fixing /tmp/tmp3faklf3z/spack/lib/spack/spack/url.py
isort checks were clean
==> Running mypy checks
Success: no issues found in 508 source files
mypy checks were clean
==> Running flake8 checks
flake8 checks were clean
==> spack style checks were clean
|
|
Looks like there is a limit on comment size: https://github.community/t/maximum-length-for-the-comment-body-in-issues-and-pr/148867
I suspect most people will just run it themselves if the bot fails -- could the bot just say "success!" and then make a recommendation to run |
|
Could it really be possible that the output would be that long? I do think having the output here is helpful - otherwise the user needs to run it themself (making the bot not super useful) or open up the CI (so many clicks!) For this likely edge case I could do a check for a little bit under that length and just truncate the output if it's too big, would that work? |
|
okay all set. |
|
And the bot already reads the status check failure (for style) and gives them a message they can run it. |
We actually do PRs that affect tons of files at once -- so esp. in the first output section (modified files) we print all the names. For some of @adamjstewart's OCD PRs it's all 5000+ packages. But given that, I think the solution isn't to limit it with the bot but in |
|
That works too! For now I added a details box so it's not visually so much text, and spackbot will always truncate within the limit. |
Signed-off-by: vsoch vsoch@users.noreply.github.com