Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pr to vsoch #32

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

tgamblin
Copy link
Collaborator

this is a thing.

@spack-bot-develop
Copy link

Hi @tgamblin! I noticed that the following package(s) don't yet have maintainers:

  • ampl
  • caffe
  • cppunit
  • dssp
  • expat
  • flecsph
  • folly
  • graphviz
  • libpng
  • libtirpc
  • openblas
  • scotch

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['tgamblin']

If not, could you contact the developers of this package and see if they are interested? Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer", it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@vsoch
Copy link
Owner

vsoch commented Jul 19, 2021

False alarm everyone! Sorry for the ping - this is a test PR for spackbot. Please unsubscribe!

@vsoch
Copy link
Owner

vsoch commented Jul 19, 2021

@spackbot hello!

Repository owner deleted a comment from spack-bot-develop bot Jul 19, 2021
@spack-bot-develop
Copy link

Hola!

@vsoch
Copy link
Owner

vsoch commented Jul 19, 2021

@spackbot fix style

@spack-bot-develop
Copy link

Let me see if I can fix that for you! This might take a moment...

@tgamblin
Copy link
Collaborator Author

@spackbot fix style

@spack-bot-develop
Copy link

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack:
  selected: isort, mypy, flake8
==> Modified files:
  lib/spack/spack/spec.py
==> Running isort checks
  Fixing /tmp/tmpp4jv609p/spack/lib/spack/spack/spec.py
  isort checks were clean
==> Running mypy checks
  Success: no issues found in 508 source files
  mypy checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. I've updated the branch with isort fixes.

@spack-bot-develop
Copy link

Let me see if I can fix that for you! This might take a moment...

@vsoch
Copy link
Owner

vsoch commented Jul 19, 2021

@spackbot fix style

@spack-bot-develop
Copy link

Let me see if I can fix that for you! This might take a moment...

@spack-bot-develop
Copy link

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack:
  selected: isort, mypy, flake8
==> Modified files:
==> Running isort checks
  isort checks were clean
==> Running mypy checks
  Success: no issues found in 508 source files
  mypy checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally!

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

@spackbot hello

@spack-bot-develop
Copy link

こんにちは!

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

@spackbot commands

@spack-bot-develop
Copy link

You can interact with me in many ways!

  • @spackbot hello: say hello and get a friendly response back!
  • @spackbot help or @spackbot commands: see this message
  • @spackbot run pipeline or @spackbot re-run pipeline: to request a new run of the GitLab CI pipeline
  • @spackbot fix style if you have write and would like me to run spack style --fix for you.

I'll also help to label your pull request and assign reviewers!
If you need help or see there might be an issue with me, open an issue here

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

@spackbot fix style

@spack-bot-develop
Copy link

Let me see if I can fix that for you! This might take a moment...

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

@spackbot fix style

@spack-bot-develop
Copy link

Let me see if I can fix that for you! This might take a moment...

@spack-bot-develop
Copy link

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack:
  selected: isort, mypy, flake8
==> Modified files:
==> Running isort checks
  isort checks were clean
==> Running mypy checks
  Success: no issues found in 512 source files
  mypy checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally!

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

@spackbot hello

@spack-bot-develop
Copy link

👋️

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

@spackbot fix style

@spack-bot-develop
Copy link

Let me see if I can fix that for you! This might take a moment...

@spack-bot-develop
Copy link

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack:
  selected: isort, mypy, flake8
==> Modified files:
==> Running isort checks
  isort checks were clean
==> Running mypy checks
  Success: no issues found in 512 source files
  mypy checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. I wasn't able to make any further changes, but please see the message above for remaining issues you can fix locally!

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

@spackbot hello!

@spack-bot-develop
Copy link

Hi! How are you?

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

I'm good, because dinner was delish. @spackbot can you tell me a joke?

@spack-bot-develop
Copy link

Why did the programmer quit his job?
Because he didn't get arrays.
😄️

@vsoch
Copy link
Owner

vsoch commented Jul 21, 2021

@spackbot you are so funny! Tell me another joke!

@spack-bot-develop
Copy link

Why do Java programmers wear glasses?
Because they don't C#
😄️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants