pythongh-111644: Enhance support threading_cleanup()

Copy the list of dangling thread to provide a consistent output between the warning and the "Dangling thread" listing.
vstinner · Nov 3, 2023 · 20c4268 · 20c4268
1 parent f21b230
commit 20c4268
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/Lib/test/support/threading_helper.py b/Lib/test/support/threading_helper.py
@@ -36,16 +36,22 @@ def threading_cleanup(*original_values):
         if not count:
             # Display a warning at the first iteration
             support.environment_altered = True
-            dangling_threads = values[1]
+
+            # Copy the thread list to get a consistent output between the
+            # warning and the "Dangling thread" listing.
+            dangling_threads = list(values[1])
+
             support.print_warning(f"threading_cleanup() failed to cleanup "
                                   f"{values[0] - original_values[0]} threads "
                                   f"(count: {values[0]}, "
                                   f"dangling: {len(dangling_threads)})")
             for thread in dangling_threads:
                 support.print_warning(f"Dangling thread: {thread!r}")
 
-            # Don't hold references to threads
+            # Break any potential reference cycle
             dangling_threads = None
+
+        # Break any potential reference cycle
         values = None
 
         time.sleep(0.01)