Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify extras_require in setup.py #35

Closed
chrahunt opened this issue Nov 10, 2018 · 1 comment
Closed

Specify extras_require in setup.py #35

chrahunt opened this issue Nov 10, 2018 · 1 comment

Comments

@chrahunt
Copy link
Contributor

chrahunt commented Nov 10, 2018

Currently hachoir-urwid and maybe other utilities have unstated external dependencies. For hachoir-urwid this is a problem because doing a plain pip install urwid will install version 2.x which seems to be incompatible (see #34). If we pass something like

'extras_require': {
    'urwid': [
        'urwid==1.3.1'
    ]
}

to the setup method in setup.py then users could pip install hachoir hachoir[urwid] and be assured they get a tried and tested version.

@vstinner
Copy link
Owner

Sure, go ahead with a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants