Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes other styles with 1.5.1 #35

Open
bmaehr opened this issue Feb 4, 2019 · 2 comments
Open

Crashes other styles with 1.5.1 #35

bmaehr opened this issue Feb 4, 2019 · 2 comments

Comments

@bmaehr
Copy link

bmaehr commented Feb 4, 2019

Hello,

It is nice to see, that bower seems to be not needed anymore by 1.5.1.

But unfortunately version 1.5.1 crashes styles of other components / the app.
For example the global style
a:not([href]):not([tabindex])
changes the color of some buttons and links.

An other effect was, that a vertical list of menu items in ribbon style was collapsed to a smaller space.

So please check your style changes and apply them only for your component and not globally.

@vsymguysung
Copy link
Owner

Could you be more detail on the issue ? It would be awesome that you could make a PR for it considering I am pretty much occupied with other projects at work these days.

@bmaehr
Copy link
Author

bmaehr commented Feb 7, 2019

I think the problem is, that you added "bootstrap": "^4.0.0-beta" as a dependency.
The problem seams to be described in twbs/bootstrap#24140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants