Pluralized types global opt-in #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference issue: #118 Allow API to produce pluralized types rather than having to configure each serializer one by one.
bcardarella
commented
Feb 20, 2017
| @@ -212,19 +212,23 @@ defmodule JaSerializer.Serializer do | |||
|
|
|||
| defp define_default_type(module) do | |||
| type_from_module = module | |||
| |> Atom.to_string | |||
| |> String.split(".") | |||
| |> Module.split() | |||
There was a problem hiding this comment.
I made a small refactor here
bcardarella
commented
Feb 20, 2017
| |> List.last | ||
| |> String.replace("Serializer", "") | ||
| |> String.replace("View", "") | ||
| |> JaSerializer.Formatter.Utils.format_type | ||
| |> JaSerializer.Formatter.Utils.format_type() | ||
| |> pluralize_type(Application.get_env(:ja_serializer, :pluralize_types)) |
There was a problem hiding this comment.
we could debate on if the pluralization should happen before or after the formatting
|
Your up early! I am totally fine with making this configurable, thanks @bcardarella. |
|
@alanpeabody can we get a release cut for this? Last time a release was deployed was Feb 19. |
|
🙏 @alanpeabody a new release on hex.pm would be a great help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #118
Allow API to produce pluralized types rather than having to configure
each serializer one by one.