Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a null terminator for byte[]. #45

Merged
merged 1 commit into from Sep 24, 2018
Merged

Conversation

dfish3r
Copy link
Member

@dfish3r dfish3r commented Sep 24, 2018

See #44.

@dfish3r
Copy link
Member Author

dfish3r commented Sep 24, 2018

I'm not certain what should be done if the input is already null terminated.
I added a check so that the terminator isn't added if it already exists.
I think the spec could be read either way.

@serac
Copy link
Member

serac commented Sep 24, 2018

I think adding iff not exists is perfectly reasonable, especially in the absence of evidence one way or the other. In the end, though, it's all about client support, so if there's an important implementation that always adds a null terminator we could justify doing that for the sake of interoperability.

@serac serac merged commit 4c54c56 into master Sep 24, 2018
@dfish3r dfish3r deleted the byte-array-null-terminator branch August 15, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants