Change constructor of a PasswordValidator acording PECS princips.

[foal]

From

public PasswordValidator(final List<Rule> rules)

to

public PasswordValidator(final List<? super Rule> rules)

see for more information http://stackoverflow.com/questions/2723397/what-is-pecs-producer-extends-consumer-super

[dfish3r]

My reading of that thread lends me to believe that we're got a producer.
And the pattern should be List<? extends Rule>.

Is there a specific compile time problem you're trying to solve?

[foal]

Easy :)

private static final List<CharacterRule> RULES = ImmutableList.of(ucimpRule);
//...
validator = new PasswordValidator(StreamEx.of(RULES).map(r -> (Rule) r).toList());

[foal]

And looks like you are right. It is a producer. So List<? extends Rule>.