Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enhanced error messages. #110

Merged
merged 5 commits into from
Jan 13, 2020
Merged

Conversation

dfish3r
Copy link
Member

@dfish3r dfish3r commented Jan 10, 2020

Update AllowedCharacterRule and IllegalCharacterRule to support per-character error messaging.

Fixes #109 .

Update AllowedCharacterRule and IllegalCharacterRule to support per-character error messaging.
@dfish3r
Copy link
Member Author

dfish3r commented Jan 10, 2020

Note that changes to PropertiesMessageResolver are potentially breaking to anyone who has implemented custom error code keys that include dot (.)

@serac
Copy link
Member

serac commented Jan 13, 2020

I think folks tend to paint in the existing lines when extending. Since the default error code keys don't contain dots, I would think consumers would naturally avoid them. That's to say I think the impact will be negligible to zero.

Copy link
Member

@serac serac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great feature with a clear and straightforward configuration. I had a couple of minor questions that I'd like to get answered before accepting.

src/main/java/org/passay/AllowedCharacterRule.java Outdated Show resolved Hide resolved
src/main/java/org/passay/PropertiesMessageResolver.java Outdated Show resolved Hide resolved
@serac serac merged commit 89beeba into master Jan 13, 2020
@serac serac deleted the multi-message-properties branch January 13, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple messages for single character based rules
2 participants