Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each project should contain separate undo stack #9

Open
vt4a2h opened this issue Oct 21, 2018 · 0 comments
Open

Each project should contain separate undo stack #9

vt4a2h opened this issue Oct 21, 2018 · 0 comments
Assignees

Comments

@vt4a2h
Copy link
Owner

vt4a2h commented Oct 21, 2018

In the current implementation we have only one undo stack for all projects. This potentially lead to inconsistency and memory leaks.

Acceptance criteria:

  1. Separate undo stack should be created per project
  2. When active project has changed, current command stack should be changed as well
  3. When project is closed, its undo stack should be dropped as well
  4. Command for changing active project shouldn't be added to any undo stack at all
  5. Deactivated project should retain its modified state (and all other states)
@vt4a2h vt4a2h self-assigned this Dec 30, 2018
vt4a2h added a commit that referenced this issue Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant