Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an email share button #145

Open
3vivekb opened this issue Nov 16, 2017 · 5 comments
Open

Add an email share button #145

3vivekb opened this issue Nov 16, 2017 · 5 comments
Assignees

Comments

@3vivekb
Copy link

3vivekb commented Nov 16, 2017

This issue is blocked by #140

Replace the feedback button,
image
With a share button,
image

Please grab the code from the original modeify and use that.
image

I'd prefer some sort of share by a webservice, or just using gmail, otherwise we'll try to figure out how to make our own webserver.

For now we'll get share by email. If we have time, we should add a share by sms option.

@3vivekb
Copy link
Author

3vivekb commented Nov 16, 2017

I'm not sure where in the code or which commit, but the original modeify is here:
https://github.com/conveyal/modeify

@3vivekb
Copy link
Author

3vivekb commented Dec 20, 2017

  • Replace Feedback with Share (and share logo similar to CarFreeAtoZ)
  • Get rid of share button at the top
  • Rearrange Name, Email to be at the top and copy link to the bottom
  • Remove directions from the body of the email
  • Don't auto copy the link till somebody clicks "Copy Link"
  • Change the wording for the Copy link (maybe just say Copy and add a header that says something like "Share Trip by Link"
  • Consider removing the body section especially if it is static (for space reasons).
  • "A link to your trip plan will be sent to the email address specified." Or similar.

@3vivekb
Copy link
Author

3vivekb commented Dec 20, 2017

  • Rebase from master

@linuxwebexpert
Copy link

Please put feedback button back and use Font Awesome Copy Clipboard icon as was shown in previous commit. We actually use the feedback button - https://www.surveymonkey.com/r/ZB63FHZ -- and have another open issue #65 to improve this feature. We do not have any issues open to remove this feature.

We cannot simply remove features without discussing the impact of those decisions.

Additionally the Share / Copy Link / Email button is top right in most web applications, not at the bottom of the page off screen where it is not visible unless you scroll down to find it, hence losing sight of your URL and the important trip details.

Comments, suggestions and thoughts appreciated.

@3vivekb
Copy link
Author

3vivekb commented Dec 21, 2017

The feedback link has already gathered a sample of results. It was always meant to be a temporary thing. We get much better feedback using the "Help Us Improve" links which is more direct and saves trip information.

What is more important for that real estate at the bottom is a share button. It isn't that far down, and it is labeled "share" so it's relatively intuitive what it is for. A Copy link button in the top right would not be intuitive.

#65 was always more theoretical than an actual goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants