-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an email share button #145
Comments
I'm not sure where in the code or which commit, but the original modeify is here: |
|
|
Please put feedback button back and use Font Awesome Copy Clipboard icon as was shown in previous commit. We actually use the feedback button - https://www.surveymonkey.com/r/ZB63FHZ -- and have another open issue #65 to improve this feature. We do not have any issues open to remove this feature. We cannot simply remove features without discussing the impact of those decisions. Additionally the Share / Copy Link / Email button is top right in most web applications, not at the bottom of the page off screen where it is not visible unless you scroll down to find it, hence losing sight of your URL and the important trip details. Comments, suggestions and thoughts appreciated. |
The feedback link has already gathered a sample of results. It was always meant to be a temporary thing. We get much better feedback using the "Help Us Improve" links which is more direct and saves trip information. What is more important for that real estate at the bottom is a share button. It isn't that far down, and it is labeled "share" so it's relatively intuitive what it is for. A Copy link button in the top right would not be intuitive. #65 was always more theoretical than an actual goal. |
This issue is blocked by #140
Replace the feedback button,
![image](https://user-images.githubusercontent.com/4524205/32911754-ee0784b0-cac1-11e7-9933-87b184a2f0a7.png)
![image](https://user-images.githubusercontent.com/4524205/32911798-138e7dba-cac2-11e7-8849-36b0822452b2.png)
With a share button,
Please grab the code from the original modeify and use that.
![image](https://user-images.githubusercontent.com/4524205/32911813-24513e08-cac2-11e7-8e08-a59e01855ebf.png)
I'd prefer some sort of share by a webservice, or just using gmail, otherwise we'll try to figure out how to make our own webserver.
For now we'll get share by email. If we have time, we should add a share by sms option.
The text was updated successfully, but these errors were encountered: