Fix cache infinite loading issue with debounce [bug fix] #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an issue when
debounceTimeout
is set where some searches will appear to "load" forever (i.e. display the loading icon), but not actually perform a search.You can test the issue yourself with the simple debounce example: https://codesandbox.io/s/5y2xq39v5k
You're not able to view the state of
AsyncPaginate
(I suppose sincecodesandbox.io
is using an iframe?). However, you can repeat the bug by following these steps:The "search" for these terms will seem to go on infinitely, and never return any results.
This is due to the
optionsCache
state variable onAsyncPaginate
being filled with the search options as they are typed. This PR moves setting the cache until after the debounce timeout, so that queries which do not run are not cached.