Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AddToCart currency values #16

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Fix AddToCart currency values #16

merged 1 commit into from
Oct 27, 2020

Conversation

klzns
Copy link
Contributor

@klzns klzns commented Oct 23, 2020

What is the purpose of this pull request?

Fix currency values of the AddToCart event

What problem is this solving?

Before After
image image

image

How should this be manually tested?

https://breno--storecomponents.myvtex.com/

Check the events in Events Manager:
https://business.facebook.com/events_manager2/list/pixel/421722368533271/test_events?business_id=471902940081896

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 23, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 23, 2020

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@klzns klzns requested review from a team, icazevedo, kaisermann and victorhmp and removed request for a team October 23, 2020 18:55
Comment on lines +61 to +67
let price
try {
price = product.items[0].sellers[0].commertialOffer.Price
} catch {
price = undefined
}
return price
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let price
try {
price = product.items[0].sellers[0].commertialOffer.Price
} catch {
price = undefined
}
return price
return product?.items?.[0]?.sellers?.[0]?.commertialOffer?.Price

@klzns klzns merged commit 651ebfa into master Oct 27, 2020
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 27, 2020

Your PR has been merged! App is being published. 🚀
Version 2.2.0 → 2.2.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.facebook-pixel@2.2.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@klzns klzns deleted the fix-add-to-cart branch October 27, 2020 15:52
@khrizzcristian
Copy link

This is not good. Now I have a product with 39.99 price.
View content event: value = 39.99
Add to cart event: value = 0.399
unnamed
unnamed (1)
9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants