Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

possibility to add class for each menu-item item #182

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hudsonlhMartins
Copy link

What problem is this solving?

currently we can't put a class for a menu item, this each limiting us a lot for styling

this is currently not possible

How to test it?

workspace

  • I left only one element of the menu with a class called hello

Screenshots or example usage:

vtex.menu@2.x:menu#menu-main": {
  "props": {
	  "orientation": "vertical",
	  "blockClass": "sub-area",
	  "items": [
                            {   
                                "blockClassItem": "hello",
                                "type": "custom",
                                "iconId": null,
                                "highlight": false,
                                "itemProps": {
                                    "type": "internal",
                                    "href": "/cozinha/para-armazenar",
                                    "tagTitle": "Para Armazenar",
                                    "text": "Para Armazenar"
                                }
                            },
            ]
  }
}
         

we use the blockClassItem

How does this PR make you feel? 馃敆

@hudsonlhMartins hudsonlhMartins requested review from a team as code owners June 8, 2023 22:39
@hudsonlhMartins hudsonlhMartins requested review from brunoamui, icazevedo, eduardoformiga and lucasfp13 and removed request for a team June 8, 2023 22:39
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 8, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

@vtex-io-docs-bot
Copy link

Beep boop 馃

Thank you so much for keeping our documentation up-to-date 鉂わ笍

@hudsonlhMartins
Copy link
Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 馃
Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 馃槥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant