Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of vtex.use-svg lib to display icons #56

Merged
merged 2 commits into from Dec 2, 2018
Merged

Use of vtex.use-svg lib to display icons #56

merged 2 commits into from Dec 2, 2018

Conversation

matheusps
Copy link
Member

What is the purpose of this pull request?

As the title says.

What problem is this solving?

Make icons more consistent throughout components.

How should this be manually tested?

Use this workspace

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@matheusps matheusps self-assigned this Nov 29, 2018
@brunojdo brunojdo merged commit 2b462ef into master Dec 2, 2018
@brunojdo brunojdo deleted the fix/icons branch December 2, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rerissondaniel rerissondaniel rerissondaniel approved these changes

@theomoura theomoura theomoura approved these changes

@brunojdo brunojdo brunojdo approved these changes

@ArthurSampaio ArthurSampaio ArthurSampaio approved these changes

@lucis lucis lucis approved these changes

Assignees

@matheusps matheusps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@matheusps @rerissondaniel @theomoura @brunojdo @ArthurSampaio @lucis